Re: [Maypole] 2.07 PR

From: Peter Speltz (peterspeltz at yahoo.com)
Date: Mon Jan 17 2005 - 22:49:36 GMT


This isn't new to 2.07 however while we're on the subject . . . Line 183 in
Maypole::Model::Base , in the is_public sub, a warning is generated when there
aren't any attributes for the sub in question. Its annoying when called in a
loop.

I replace line 183:

my $attrs = join " ", attributes::get($cv);

with these 2 lines:

 my @attrs = attributes::get($cv) || ();
 my $attrs = join " ", @attrs;

Another thought on is_public: perhaps it should take an attribute argument in
case you already have the attributes. I overrode mine to use one because i
check for different types of attributes like so in one place:
my @attrs = attributes::get($cv);
my $attrs = join ' ', @attrs;
if $class->is_public( $method, $attrs) { . . . }
if $class->is_class($method, $attrs) {...}
if $class->is_object($method, $attrs ) {....}

thanks

=====
pjs

                
__________________________________
Do you Yahoo!?
Take Yahoo! Mail with you! Get it on your mobile phone.
http://mobile.yahoo.com/maildemo

_______________________________________________
maypole mailing list
maypole at lists.netthink.co.uk
http://lists.netthink.co.uk/listinfo/maypole



This archive was generated by hypermail 2.1.3 : Thu Feb 24 2005 - 22:25:57 GMT