Simon Flack wrote:
> I'd appreciate some feedback on this this release before I upload it to
> the CPAN.
Here's what I looked at today ...
> Here's the relevant block from the Changes file:
>
> Internal changes:
> - Removed Maypole::Model->description.
Excellent. My Description columns work :)
> Fixes:
> - Model->process() shouldn't set $r->objects() to a list with a single,
> undefined element
This works, I think.
> - Fixed overriding $r->template_args->{classmetadata} in M::V::Base
This works.
> (Thanks to Dave Howorth for spotting the mistake)
This works.
> - #9473: Maypole::Model::CDBI->related_class (Thanks David Baird)
This works.
> - #9434: M::M::CDBI->search generated "uninitialized value" warnings
Haven't seen any today :)
> Templates:
M::V::TT still doesn't allow .tt extensions :(
It's difficult for me to test the templates because mine look
considerably different now. (I've done away with classmetadata.cgi
altogether since it just duplicates to_field; I use my loader to
generate text strings; I use some modified accessor_names (these break
the view_item macro BTW); I check explicitly for primary keys not just
'id' cols; ...)
So I'm just reading the code and modifying my templates rather than
actually running these templates. Results may vary.
> - The addnew template will attempt to prefill form fields with
> request parameters
This seems to work.
I take it this is for use when errors arise and addnew is now included
by the edit template?
BUT on the list page it also appears to cause search parameters to be
transferred to the addnew box after pressing 'search'. This seems wrong.
> - edit template includes 'addnew' if there is no object to edit
M::MM::CDBI::do_edit() still runs create/update_from_cgi in an eval and
puts fatal errors in errors.FATAL. I still think that is wrong; I think
there should at a minimum be an Apache error log entry for a fatal error.
If you do think that users should see Perl error messages (I don't :),
errors.FATAL needs to be displayed in the template. At present fatal
untaint errors are still silent.
There's a beer/addnew as well as a factory/addnew. beer/addnew looks out
of date, and I don't remember if there's a reason it should exist at all?
Cheers, Dave
_______________________________________________
maypole mailing list
maypole at lists.netthink.co.uk
http://lists.netthink.co.uk/listinfo/maypole
This archive was generated by hypermail 2.1.3 : Thu Feb 24 2005 - 22:25:57 GMT