Hey.
Simon, I see you've reworked headers support in Maypole. It looks very
clean, and I'm not going debate if the extra two objects on each
request will affect performance, however I did find a few issues with
the implementation.
The reason I added extra_headers was I need to set
$r->{extra_headers}{"Content-Disposition"} to set downloads with a
given filename in mitiki. That seems to be foiled by
next if /^Content-/; - so I've changed it to
next if /^Content-(Type|Length)/;
Also, Apache::MVC was creating a new HTTP::Headers for in rather than
Maypole::Headers. Finally, I added a note in the HTTP::Headers
synopsis, as it seemed confusing that headers_out was created manually
there.
Anyhow, it seems to work fine for me now. Good work.
Ps. I accidentally commited a more controversial change as well,
setting action to "index" for those cases where it's not defined. I
want this to go into Maypole, maybe even with a change to set action to
first args if action isn't public. (ie /page/NotPublicAction ->
/page/index/NotPublicAction) but I understand this is controversial, if
you don't like the default-action change, just revert it.
Marcus
_______________________________________________
maypole-dev mailing list
maypole-dev at lists.netthink.co.uk
http://lists.netthink.co.uk/listinfo/maypole-dev
This archive was generated by hypermail 2.1.3 : Thu Feb 24 2005 - 22:25:57 GMT