[Maypole-dev] [PATCH] Search fix

From: Dagfinn Ilmari Mannsåker (ilmari at ilmari.org)
Date: Sun Dec 05 2004 - 21:01:15 GMT


Simon Flack <sf at flacks.net> wrote:
>
> On Sun, 05 Dec 2004 21:06:51 +0100, Dagfinn Ilmari Mannsåker wrote
> > I don't know if this is an Apache2-ism, but when submitting the
> > search form, all the files are included in $r->{params}, even the
> > empty ones. So, when building the search, we need to include only
> > the non-empty ones. Here's a patch:
[...]
> That looks reasonable, but what happens if you really do want to
> search where the value for a column is an empty string or NULL?

How does the user express that in the search form?

The problem was that the old version required all unspecified fields to
be LIKE '', i.e. empty. This could be worked around with something like
"length $params{$_} ? $params{$_} : '%'", but that would still exclude
NULL fields.

The only sane thing is to allow any value for (i.e. not specify in the
where clause) columns with empty fields in the search form.

-- 
ilmari

_______________________________________________ maypole-dev mailing list maypole-dev at lists.netthink.co.uk http://lists.netthink.co.uk/listinfo/maypole-dev



This archive was generated by hypermail 2.1.3 : Thu Feb 24 2005 - 22:25:57 GMT