Re: [Maypole] AsForm and textarea

From: Tony Bowden (tony-maypole at kasei.com)
Date: Mon Oct 18 2004 - 11:42:35 BST


On Mon, Oct 18, 2004 at 09:12:17AM +0100, Stephen Quinney wrote:
> Simon no longer maintains any CPAN modules, it looks like Tony Bowden
> has stepped up to look after CDBI::AsForm,

Yep.

> It looks to me like that patch cannot be applied directly into the
> mainline CDBI::AsForm as it makes use of the function
> CDBI::mysql::column_type(). This could leave the module unusable for
> any other database. It also does not 'use' that module first so it
> relies on the assumption that it has been loaded elsewhere in the
> application first.

Well, the patch actually does test to see if it'll be able to use it:

+ my @enum = $class->enum_vals($field) if $class->can('enum_vals') &&
+ Class::DBI::mysql::column_type($class, $field) =~ /^ENUM/i;

However, that's still pretty far from ideal.

Suggestions welcome.

Tony

_______________________________________________
maypole mailing list
maypole at lists.netthink.co.uk
http://lists.netthink.co.uk/listinfo/maypole



This archive was generated by hypermail 2.1.3 : Thu Feb 24 2005 - 22:25:56 GMT